Skip to content

Conversation

@github-actions
Copy link
Contributor

No description provided.

@dessyordanova dessyordanova self-assigned this Jun 13, 2025
@dessyordanova dessyordanova requested a review from Copilot June 13, 2025 08:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a comprehensive knowledge base article that explains how to fix missing content in exported PDF files generated using RadWordsProcessing by implementing a custom FontsProvider.

  • Introduces a new KB article in Markdown format
  • Provides a sample C# implementation demonstrating how to override GetFontData in a custom FontsProvider class and configure FixedExtensibilityManager
Comments suppressed due to low confidence (1)

knowledge-base/missing-content-pdf-radwordsprocessing.md:58

  • Consider using Path.Combine to join the folder path and file name instead of string concatenation, ensuring better cross-platform compatibility and readability.
using (FileStream fileStream = File.OpenRead(this.fontFolder + "\" + fontFileName))

Comment on lines +46 to +49
fontFolder = @"..\..\..\";
var fontData = this.GetFontDataFromFontFolder("David.ttf");
fontFolder = Environment.GetFolderPath(Environment.SpecialFolder.Fonts);
return fontData;
Copy link

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid modifying the instance variable 'fontFolder' directly for temporary folder changes, as this could introduce thread-safety issues; consider using a local variable instead.

Suggested change
fontFolder = @"..\..\..\";
var fontData = this.GetFontDataFromFontFolder("David.ttf");
fontFolder = Environment.GetFolderPath(Environment.SpecialFolder.Fonts);
return fontData;
string temporaryFontFolder = @"..\..\..\";
var fontData = this.GetFontDataFromFontFolder(temporaryFontFolder + "\\" + "David.ttf");
return fontData;
return fontData;

Copilot uses AI. Check for mistakes.
@dessyordanova dessyordanova added For Review Should be reviewed by a team member. Provide feedback using comments wherever is necessary labels Jun 18, 2025
@dessyordanova dessyordanova requested review from YoanKar June 18, 2025 11:07
@dessyordanova dessyordanova merged commit 003ad61 into master Jun 19, 2025
@dessyordanova dessyordanova deleted the new-kb-missing-content-pdf-radwordsprocessing-df287a38087146ca9477b8bfa2d358ad branch June 19, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Review Should be reviewed by a team member. Provide feedback using comments wherever is necessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants